-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
|
i'd set a fixed width to the countdown, it bounces around, probably for @biocom |
2afa517
to
da445af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfect!
Hey @alfetopito . great changes! |
mentioned this in slack but do we not usually depend on the block timestamp instead of computer machine time? (considering the latter can be manipulated via changing machine local time) |
Great to see this :)
@W3stside Yes indeed, need to review this once merged. Countdown for the simple airdrop window would be nice too (as @elena-zh suggested). A suggestion to simplify, but requires a bit more of a logic implementation:
I see benefit in seeing a clear date/time stamp + a countdown combination. If I want to 'save the date' in my calendar, and only see a countdown, I have to reverse count and figure out the actual time stamp (Yes a tooltip could work here, but what about mobile?). |
da445af
to
372b1fb
Compare
Easy to add, just need to find out where. Thus it might be better if you do it @biocom
I have a dumb idea for implementing this but need a better suggestion to present it: I'll push that in another PR to not mix up things, and can be accepted or not. |
Well, the code is based on Uni's claim stuff and they did rely on system clock.
|
Yeah there was a bug there. It has since been fixed and merge onto
Agree we should. Left it up to @biocom as it'll make more sense he add and style it at once. |
Actually, added the airdrop end date to the component #2178 |
Summary
Closes #2120
Wiring up the countdown in the Claim table
Seconds is a bonus that I can remove if it doesn't look good.
Anywhere else we should have a countdown?
To Test
Watch the count going down
Background
Optional: Give background information for changes you've made, that might be difficult to explain via comments