Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Claim change account #2173

Merged
merged 9 commits into from
Jan 18, 2022
Merged

Claim change account #2173

merged 9 commits into from
Jan 18, 2022

Conversation

W3stside
Copy link
Contributor

Summary

Closes #2097

DO NOT show "Change account" button on last investment step as seen in issue linked.
On user account change (in wallet) reset them to the ClaimsTable and initial investment step

To Test

  1. use an account with investment
  2. get to last step
  3. change account and see where ya at
  4. click next after selecting an investment and see you are at step 1

@W3stside W3stside changed the base branch from develop to claim January 17, 2022 17:43
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@elena-zh
Copy link

Hey @W3stside , I'd remove 'Change account' from the 'Claiming' screen as well. WDYT?
image

@elena-zh
Copy link

elena-zh commented Jan 18, 2022

I also have found an issue, that seems to be related to the current PR: set allowance form is empty when change an account. See the video: https://watch.screencastify.com/v/11AejUiOcRtM5XV8AILH
Steps:

  1. Connect to a wallet in Rinkeby with account that has investment claims
  2. Select investment claim
  3. Navigate to the Sett allowance screen
  4. Press on the 'Change account'
  5. Fill in Recipient field with the same account
  6. Press on the 'Check claimable vCOW' button

AR: set allowance form does not contains claim options

As expected result, I would propose redirect to the ClaimsTable and initial investment step from each screen on Claim page, as the same issue is reproducible when change an account from the 'Claiming vCOW is a two step process' screen.

When enter another account, the next screen might be displayed (without showing a claim amount)
image

@W3stside W3stside requested a review from a team January 18, 2022 10:30
@fairlighteth
Copy link
Contributor

Spotted the same issues @elena-zh mentioned. Also a small merge conflict pending.

@W3stside W3stside force-pushed the claim-change-account branch from 2842e2e to 93fdf83 Compare January 18, 2022 12:06
@W3stside
Copy link
Contributor Author

4d79426

nice catch!

fixed here: 4d79426

@elena-zh
Copy link

Hey @W3stside , Is this issue related to the current PR?
image
Steps are in the video: https://watch.screencastify.com/v/oL02VLk1qKgRbqmAZ8YS

@elena-zh
Copy link

@W3stside , 'Change account' has started to be displayed in the 'Confirm transaction to claim all vCOW' screens:
image
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLAIM] Switch account functionality
5 participants