This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Claim style improve 10 #2174
Merged
Claim style improve 10 #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fairlighteth
commented
Jan 17, 2022
•
fairlighteth
commented
- Text changes
- Input field style changes
|
|
Hey @biocom , test and input field changes LGTM. |
W3stside
reviewed
Jan 18, 2022
| </span> | ||
| <label> | ||
| <input | ||
| // disabled |
There was a problem hiding this comment.
should it not be disabled via the attribute?
There was a problem hiding this comment.
My impression was this disabled attribute isn't set dynamically yet. And needed it to be not disabled for styling purposes. Commenting out as we need to address this still.
There was a problem hiding this comment.
got it, thought it was always disabled for this state, misread that. what are the criteria for disabled? we need to make an issue for this right?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.