This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Rename constants #2180
Merged
Rename constants #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
W3stside
approved these changes
Jan 18, 2022
|
@anxolin merging in base |
probably new hook from leandro. Will rebase and fix |
anxolin
force-pushed
the
rename_time_constant
branch
from
a1bf3a7 to
bee198b
Compare
maria-vslvn
pushed a commit
that referenced
this pull request
Jan 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tiny rename of constants so they don't have their value in their own name
i had to shorten the times and it was a bit unnatural to just say
const TWO_WEEKS = ms'30 minutes'