-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
actually why is max written in abbreviated form? can and should just be |
|
@W3stside The shorter the better (because of a variable Will commit. |
… into claim-styleImprove-11
@biocom , I was also able to catch the app crash when I entered a period/comma into the input amount (decimal that starts with 0). Btw, impossible to enter '0' into the field the same is when I enter letters. special symbols, etc. Also, the app is crashed when enter an amount, then clear out the field. |
Yes, this is a scenario where we need to enable the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving!
I see there's some issues, however the two PRs michel is working on are mostly to tackle design.
The error for input empty string for example, could be dealt in a future PR. Actually @nenadV91 is working in sth similar, so i think we can ignore for now.
Same as investing on behalf of someone else, Elena you are right! although we will deal in another one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Further investment flow styling. * Further investment flow styling. * Further investment flow styling. * Further investment flow styling.
Add token symbol images.
Thank you Co-authored-by: Leandro Boscariol <[email protected]>
Remove unused function.
Summary
Account used:
0x4bD39704a83dCB41B74b550988A832b83d5b9Cb0
Tries the achieve:
Price
element.value
attribute is always0
(String) based oninvestedAmount
. Prefer to return an empty string so it falls back to theplaceholder
attribute behavior.Note
max
attribute is currently not respected. Even when adding thetype="number"
attribute/value to theInput
element. Probably something to do for theonChange
handler.Screen.Recording.2022-01-18.at.12.46.56.mov