This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Change contract #2210
Merged
Change contract #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert "Revert "Renamed vCOW abi function wethPrice to nativeTokenPrice"" This reverts commit e7197dd. * Updated contract address to latest * Replaced wethPrice with nativeTokenPrice Co-authored-by: Leandro <[email protected]>
alfetopito
force-pushed
the
change-contract
branch
from
eec4456 to
f3e0f58
Compare
|
|
Updated contract and now it works for claiming ETH: https://rinkeby.etherscan.io/tx/0xb30846cec9ad3941af4ace71f581a4cf5c23d8f4b0add6ca37ffdb0ea2b0b9e2 |
|
Worked for claiming USDC and GNO as well https://rinkeby.etherscan.io/tx/0xfd6e9cf49891a9a512f8a3df3e555df2944ce4007e52f5773e610e345b24795c |
|
it's still failing for GNO... I can confirm that the same thing, in the previous version works: |
|
All right! this is not comming from this branch, my error was i didn't have balance for investing. I thought i was connected using another account, and the validation gives you the message but it doesn't stop you from continuing. |
|
👌APPROVE |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bring back the changes of ABI code from @alfetopito
It was breaking the ETH investment
Original: #2194
Summary
Follow up to #2182
Updating contract address
Updating ABI and related methods, replacing
wethPricebynativeTokenPriceTo Test
Addresses