Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Claim pending icon spinner and show timezone. #2235

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

fairlighteth
Copy link
Contributor

Summary

  • Show a pending spinner with the cow token
Screen.Recording.2022-01-20.at.18.42.48.mov
  • Show the time zone explicitly (we could also show the offset time instead, e.g. GMT+1)

Screen Shot 2022-01-20 at 18 44 03

@fairlighteth fairlighteth requested review from a team January 20, 2022 17:46
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super nice! the effect is hypnotizing, i can't stop looking at it

<i>{airdropDeadline && new Date(airdropDeadline).toLocaleString()}</i>
<i>
{airdropDeadline && new Date(airdropDeadline).toLocaleString()} (
{Intl.DateTimeFormat().resolvedOptions().timeZone})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this to a function in utils/time.ts that would do the whole formatting?
formatDateWithTimezone(date):string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes probably cleaner as we could use it in the claim table as well!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Michel, I can take care of refactoring and you can focus on the UI ✨ magic ✨

@fairlighteth
Copy link
Contributor Author

👏

Michel, I can take care of refactoring and you can focus on the UI ✨ magic ✨

Appreciate it, thank you 🪄

@alfetopito alfetopito merged commit d775d94 into develop Jan 20, 2022
@alfetopito alfetopito deleted the claim-styleImprove-26 branch January 20, 2022 20:03
@alfetopito alfetopito mentioned this pull request Jan 20, 2022
@elena-zh
Copy link

Looks great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants