-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great cleanups.
I don't think is from this PR, but I think we should always use this formatter with thousands separators. In your screenshot we can see it without
Yes, I'll get there :) |
Small suggestion after seeing the last screenshot:
|
@biocom Like this? |
0a4fb15
to
10b8a86
Compare
I've applied the change as suggested. If we want to get back the remaining % just revert the commit 10b8a86 |
@alfetopito I actually meant to have a conditional note:
But at the end, I like this general note as well, as it covers both scenarios. |
Summary
Follow up to #2232