This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Consistent locale on claim #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Seems that 'Max investment available' amount is not adjusted on the Set allowance screen
|
W3stside
approved these changes
Jan 21, 2022
added 5 commits
January 21, 2022 07:45
alfetopito
force-pushed
the
consistent-locale-on-claim
branch
from
cc82b1a to
103fea8
Compare
Great catch Elena, fixed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Making locale and decimals consistent in the claim stuff
To Test
Check all display values (not input) respect local and have thousand separators when it applies
Background
Only checked the claim related files.
Full check in the app to be done in another task