-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
|
Nice looks good! Will style further in upcoming PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to lazyness and simplicity I decided not to. And because of that I don't have the amount until the tx is sent. I could pass a callback to the claim callback but that does not sound like a good idea. The alternative is to repeat the calculation outside of the claim callback. I can do that if you think this is a must, but I don't think it's a big deal not having it until the tx is sent |
Not that bad. I think is nice to see while you sign it, but imo we can live without it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good!
LGTM! |
Summary
Show claimed amount on success screen:
Claimed amount is stored on redux as a locale aware formatted amount string
It's saved after the claim callback returns (after user sends tx)
To Test