Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Add link to the profile #2269

Merged
merged 4 commits into from
Jan 24, 2022
Merged

Add link to the profile #2269

merged 4 commits into from
Jan 24, 2022

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Jan 23, 2022

Summary

Adds link to the profile.

  • ⚠️ This link won't be visible when you claim on behalf of someone else. This is because, this someone else is the one that received the tokens, not the connected account. The profile shows the balance only for the connected wallet.

image

Not included

I didn't include any style. I assume @biocom will revisit this screen completely. Michel, let us know if you want help mocking the app to get to this screen without the need to claim tokens each time.

To Test

  1. Claim for your self. You might need to use some of the PK in https://docs.google.com/spreadsheets/d/1pf97wtawkibZPNTrVbyo2FSZKXf6Xo_A0sddWXKxnE4/edit#gid=390159133
  2. Verify the link is visible

@anxolin anxolin requested review from a team January 23, 2022 21:33
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

Hey @anxolin , great changes!

Just small improvements I'd like to suggest:

  1. It would be nice to navigate a user to the top of the Profile page when press on the 'Profile' link
    Video: https://watch.screencastify.com/v/NokA3oJZ9G2ctQtooi6r

  2. It would be nice to add a message that tokens were claimed for the account < account > . WDYT?
    image

Copy link
Contributor

@W3stside W3stside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styles are a bit strange but that's not for this PR, approved

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and I second Elena's suggestion of showing which account this was claimed to, to be explicit

@anxolin
Copy link
Contributor Author

anxolin commented Jan 24, 2022

  1. It would be nice to navigate a user to the top of the Profile page when press on the 'Profile' link

Agree, however, i think this is true for every navigation. So, i assume we should have a middleware or something. I will add this in our list of good to haves.

  1. It would be nice to add a message that tokens were claimed for the account < account > . WDYT?

Sounds good. I will just add something basic. I think Michel will just move things around, so I'll try to not over do it.

@anxolin
Copy link
Contributor Author

anxolin commented Jan 24, 2022

For 2.
image

Yes, it needs styles :)

@anxolin anxolin merged commit bdb4403 into develop Jan 24, 2022
@alfetopito alfetopito deleted the add-link-profile branch January 25, 2022 00:15
maria-vslvn pushed a commit that referenced this pull request Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants