Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Style claim and invest page. #2294

Merged
merged 4 commits into from
Jan 26, 2022
Merged

Style claim and invest page. #2294

merged 4 commits into from
Jan 26, 2022

Conversation

fairlighteth
Copy link
Contributor

Summary

  • Styles the invest description page

Screen Shot 2022-01-25 at 14 51 48

Screen Shot 2022-01-25 at 14 51 11

Screen Shot 2022-01-25 at 14 51 00

@fairlighteth fairlighteth requested review from a team January 25, 2022 14:01
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

}

> span::before {
content: 'Step ' attr(data-step);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't personally like this it makes it quite hard to change later on if we forget it's in the CSS. Can't you just write this out in the HTML of InvestmentFlow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@W3stside Agreed, addressed now.

@elena-zh
Copy link

Looks great besides the stepper in a mobile view.
image

@W3stside
Copy link
Contributor

point this to release/1.10

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure I left a review on this a few moments ago...
Or maybe I did in another PR 🤷

Anyway, looks good, except the stepper as Elena points out

@fairlighteth fairlighteth changed the base branch from develop to release/1.10 January 25, 2022 18:07
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super nice other than what has been reported

Not from this PR, but i just noticed while testing this. The vCOW logo shrunk too much:
image

</StepExplainer>
<p>
For more details around the token, please read{' '}
<ExternalLink href={COW_LINKS.vCowPost}>the blog post</ExternalLink>. For more details about the claiming
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we give a line break for the other For more details... ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes or we could try to write a single sentence pointing to both links (don't have a suggestion for that now :) )

@fairlighteth
Copy link
Contributor Author

@elena-zh Pushed a fix for that:
Screen Shot 2022-01-25 at 19 21 36

@fairlighteth
Copy link
Contributor Author

Looks super nice other than what has been reported

Not from this PR, but i just noticed while testing this. The vCOW logo shrunk too much: image

Will review in a separate PR. Might have addressed it already.

@elena-zh
Copy link

@biocom , the 2nd step text is left-aligned now on all types of mobile devices when screen width is less than 395 px
image

@fairlighteth
Copy link
Contributor Author

fairlighteth commented Jan 26, 2022

@elena-zh should be fixed now. Merging to expedite, feel free to address post merge.

@fairlighteth fairlighteth merged commit 82736a0 into release/1.10 Jan 26, 2022
@elena-zh
Copy link

Looks good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants