-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
|
src/custom/pages/Claim/styled.ts
Outdated
} | ||
|
||
> span::before { | ||
content: 'Step ' attr(data-step); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't personally like this it makes it quite hard to change later on if we forget it's in the CSS. Can't you just write this out in the HTML of InvestmentFlow
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@W3stside Agreed, addressed now.
point this to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure I left a review on this a few moments ago...
Or maybe I did in another PR 🤷
Anyway, looks good, except the stepper as Elena points out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</StepExplainer> | ||
<p> | ||
For more details around the token, please read{' '} | ||
<ExternalLink href={COW_LINKS.vCowPost}>the blog post</ExternalLink>. For more details about the claiming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should we give a line break for the other For more details...
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes or we could try to write a single sentence pointing to both links (don't have a suggestion for that now :) )
@elena-zh Pushed a fix for that: |
@biocom , the 2nd step text is left-aligned now on all types of mobile devices when screen width is less than 395 px |
@elena-zh should be fixed now. Merging to expedite, feel free to address post merge. |
Looks good, thanks! |
Summary