Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Iterate success page post merge. #2302

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

fairlighteth
Copy link
Contributor

Summary

Screen Shot 2022-01-26 at 12 58 00

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I paste the other relevant screenshot. When you claim for someone else

image

@W3stside
Copy link
Contributor

should we show full claim amount (not smart) here?

@fairlighteth
Copy link
Contributor Author

should we show full claim amount (not smart) here?

@W3stside Open to both. Not sure how long that number can get (showing in full). Can take it on a different PR as long as we're in line with the ClaimSummary amount on the first page.

Merging as discussed.

@fairlighteth fairlighteth merged commit 278f311 into release/1.10 Jan 26, 2022
@elena-zh
Copy link

LGTM!
The only strange thing I noticed that a claimed amount disappears when go back to the Claimed page.
I reported it here #2219 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants