Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Use cards for claim/receive accounts. #2312

Merged
merged 10 commits into from
Jan 27, 2022
Merged

Conversation

fairlighteth
Copy link
Contributor

Summary

  • Styles the claim/receive accounts
  • For now keeping the Badge colors provided by the component @anxolin added.

Screen Shot 2022-01-26 at 18 32 24

Screen Shot 2022-01-26 at 18 32 16

@fairlighteth fairlighteth requested review from a team January 26, 2022 17:34
@fairlighteth
Copy link
Contributor Author

Just noticed the icon color in light mode. Will address.

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@fairlighteth
Copy link
Contributor Author

Fix pushed for the icon color in light mode:
Screen Shot 2022-01-26 at 18 54 18

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can you make it look so good?

Approved, just small suggestion regarding the semantics of a prop

@elena-zh
Copy link

@biocom , magic you do!
But could we make addresses arrows clickable?
image

Also, could we show these addresses in 1 line in a mobile view?
image

Thanks!

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are a 🧙‍♀️

@fairlighteth
Copy link
Contributor Author

@elena-zh Thanks for reporting. Pushed a fix for both items:
Screen Shot 2022-01-26 at 21 16 38

Mobile
Screen Shot 2022-01-26 at 21 15 59

@fairlighteth
Copy link
Contributor Author

Merging to keep release up to date.
@anxolin Feel free to modify wording as you see fit, based on the comment thread in this PR
@elena-zh please review the 2 points I addressed

@fairlighteth fairlighteth merged commit e6476d9 into release/1.10 Jan 27, 2022
@elena-zh
Copy link

Hey @biocom , looks great now!
Tiny-tiny nitpick is that navigation arrow has a bit differently underlined than an address in Win10+Chrome
image

As an expected result I'd prefer it underlined the same way as we do for 'View all orders' link or so
image

But anyways, if you think that this nitpick worth effort, it will be addressed in another PR.

Thanks!

@alfetopito alfetopito deleted the success-page-accounts branch February 1, 2022 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants