Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Add vCOW banner link. #2326

Merged
merged 3 commits into from
Jan 27, 2022
Merged

Add vCOW banner link. #2326

merged 3 commits into from
Jan 27, 2022

Conversation

fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Jan 27, 2022

Summary

  • Adds a vCOW banner. Previously this was a text link below the primary action button.
Screen.Recording.2022-01-27.at.12.09.19.mov

Screen Shot 2022-01-27 at 12 09 33

Screen Shot 2022-01-27 at 12 10 27

Note

  • Please review the text in case we want to modify this. Just put a suggestion in place in this PR.

@fairlighteth fairlighteth requested review from a team January 27, 2022 11:13
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🔥

I think is perfect. Now, there shouldn't be so many questions regarding the investment and vesting, at least people will see the post for sure.

@avsavsavs @annamsgeorge maybe you will like to check this PR one

@elena-zh
Copy link

Looks great!

But don't we want to add it to these screens?
image
image

Currently, we have 'Read more' there

@fairlighteth
Copy link
Contributor Author

@elena-zh Yes, I see your point. Question is, how relevant is it to see that banner considering:

  • I have no claim account inputted yet.
  • I have a claim account without any claims.

From one side, you could say it only adds noise to add the banner there. Curious on your thoughts.

I do think we need to add it here (airdrop only)
Screen Shot 2022-01-27 at 13 21 37

@fairlighteth
Copy link
Contributor Author

@elena-zh Pushed an update to show the banner for the simple airdrop case:
Screen Shot 2022-01-27 at 13 27 14

@elena-zh
Copy link

@biocom , thanks for adding the banner to the Airdrop screen!

From one side, you could say it only adds noise to add the banner there. Curious on your thoughts.

Agree.
The only one 'pros' for adding this banner to 0 screens is that a user might want to read about vCOW and learn more about it.
Previously we provided this opportunity, now we don't.
As an option, we could leave 'Read more' link instead of the banner on these screens in order not to add noise.

@elena-zh
Copy link

@biocom , another nitpick: link arrow is displayed in a separate line in iPhone 12 mini.
Does this issue worth fixing or we can leave it as it is for now?
image

@fairlighteth
Copy link
Contributor Author

@biocom , another nitpick: link arrow is displayed in a separate line in iPhone 12 mini. Does this issue worth fixing or we can leave it as it is for now? image

One quick way to fix is to add a few extra words...this banner component is shared so seems to be a more practical solution for now.

* Add vesting banner.

* Fix a:focus
@fairlighteth
Copy link
Contributor Author

Merged in the vesting banner PR to consolidate (#2327)

@fairlighteth fairlighteth merged commit 783ada1 into release/1.10 Jan 27, 2022
@alfetopito alfetopito deleted the vcow-banner branch January 27, 2022 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants