-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
|
Probably does not make sense to also set the 'Receive XXX vCOW' accordingly right? I guess by keeping it at 0, it emphasizes the error. |
stop setting the base to develop 😂 |
Hey @anxolin , works great when claim on behalf. |
I just did some changes to decouple setting the % from the error/warnings. IMO, they are not connected. Some nice change this brings in my opinion, is that if you invest more than the MAX, you will see 100% not 0%. For me it creates a weird effect when you add an extra 0, and then remove for example (used to go from 100% to 0% and then back to 100%. I feel the error is clear enough, so is ok to have the 100% even if the user has inputed a high number. |
1d1e58f
to
1d7beda
Compare
1d7beda
to
ce7a28a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
LGTM! |
Summary
This PR tries to improve this case:
The problem here is that is not clear enough why there's an error. In principle, we should assume users are educated about the investment and they have read the blog post where we mention that investing for others requires investing 100% of the oportunity.
the problem above in my opinion, is that we are not hinting this is the case.
The proposed solution, is to do these small actions:

Additionally, for the case of investing with zero balance, i thought the messages were too long, so i did a specific message for it:

To Test