This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
2245/hide claims while loading #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfetopito
commented
Jan 27, 2022
| type ClaimIntroductionProps = Pick<ClaimCommonTypes, 'hasClaims' | 'handleChangeAccount'> & { | ||
| isAirdropOnly: boolean | ||
| } | ||
| type ClaimIntroductionProps = Pick<ClaimCommonTypes, 'hasClaims' | 'handleChangeAccount' | 'isAirdropOnly'> |
There was a problem hiding this comment.
Refactored props for a couple of components
alfetopito
commented
Jan 27, 2022
Comment on lines
+115
to
-127
| export default function ClaimsTable({ isAirdropOnly, claims, hasClaims }: ClaimsTableProps) { | ||
| const { selectedAll, selected, activeClaimAccount, claimStatus, isInvestFlowActive } = useClaimState() | ||
|
|
||
| const { setSelectedAll, setSelected } = useClaimDispatchers() | ||
|
|
||
| const pendingClaimsSet = useAllClaimingTransactionIndices() | ||
|
|
||
| const userClaimData = useUserEnhancedClaimData(activeClaimAccount) | ||
|
|
There was a problem hiding this comment.
Passing down as props to avoid fetching the same thing in 3 different places and cause additional UI delays
alfetopito
commented
Jan 27, 2022
| import EligibleBanner from './EligibleBanner' | ||
| import FooterNavButtons from './FooterNavButtons' | ||
| import InvestmentFlow from './InvestmentFlow' | ||
| import { ClaimSummary } from './ClaimSummary' |
There was a problem hiding this comment.
A lot of noise I know, but the imports were a mess.
Split them by "category"
alfetopito
commented
Jan 27, 2022
| * | ||
| * @param account | ||
| */ | ||
| export function useUserHasAvailableClaim(account: Account): boolean { |
|
|
Great! |
elena-zh
approved these changes
Jan 28, 2022
nenadV91
reviewed
Jan 28, 2022
added 8 commits
January 28, 2022 09:40
To take claims as parameter to avoid unnecessary hook calls
alfetopito
force-pushed
the
2245/hide-claims-while-loading
branch
from
9dc89da to
7e8b7ca
Compare
alfetopito
added a commit
that referenced
this pull request
Jan 28, 2022
* Removed unused hook * Made claim loading return an isLoading state * Refactored ClaimsTable and Investment flow To take claims as parameter to avoid unnecessary hook calls * Added a very ugly loader to claims page * Organized a bit claim/index imports mess * Refactoring claim page components props * Start hook loading by default * Show loader inside modal. Still ugly Co-authored-by: Leandro <[email protected]>
ramirotw
pushed a commit
that referenced
this pull request
Feb 18, 2022
* fix: only try SafeApp connection in an iframe Improves non-iframe pageload by 300ms. Fixes #2338. The Gnosis check for a SafeApp races a postMessage and a 300ms timeout [1]. The SafeApp embeds the interface in an iframe, so this avoids the check when not in iframes. [1]: https://github.com/gnosis/safe-apps-sdk/blob/f224869dd5ae810db8cecad08fbbcfaa6c046d9d/packages/safe-apps-web3-react/src/connector.ts#L52 * refactor: IS_IN_IFRAME const
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2245
Hide claims until loading is finished
For now I'm using a very ugly basic loader
Not in the scope of this PR to make it look nice
To Test