Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Check pending claims for disconnected accounts #2341

Merged
merged 3 commits into from
Jan 28, 2022

Conversation

alfetopito
Copy link
Contributor

@alfetopito alfetopito commented Jan 27, 2022

Summary

Checks claims on all not only for the connected wallet.
Also as a side effect allows to check claims when no wallet is connected

EDIT 2022-01-28

  • No longer checking the connected account by default. Only if that's selected in the claim UI

  • Updated banner text to make clear it's for the checked account
    Screen Shot 2022-01-28 at 08 24 17

    To Test

  1. While connected to rinkeby, check claims for one account that has mainnet and/or gchain claims
  • The claims banner should be displayed
  1. While disconnected, check the same account
  • The same banner should be displayed

@alfetopito alfetopito self-assigned this Jan 27, 2022
@alfetopito alfetopito requested review from a team January 27, 2022 22:27
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

@alfetopito , works fine to me!
However, here I'd definitely separate banners and show:

  • for myself: You have other available claims on <>'
  • for another account: 'This account has other available claims on <>'
    WDYT?

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue. Simple fix. Easy review. Like ❤️

@alfetopito
Copy link
Contributor Author

@alfetopito , works fine to me! However, here I'd definitely separate banners and show:

* for myself: `You have other available claims on <>'`

* for another account: `'This account has other available claims on <>'`
  WDYT?

I think it shouldn't differentiate when it's your account or the one being checked.
Right now it's checking for the connected account even if you don't actively check for that.
I'll update to remove this and only work for the checked account instead.

@alfetopito alfetopito merged commit 32c2f4f into release/1.10 Jan 28, 2022
@alfetopito alfetopito deleted the check-claim-all-networks-active-account branch January 28, 2022 17:40
alfetopito added a commit that referenced this pull request Jan 28, 2022
* Check pending claims for disconnected accounts

* Updated claims available banner message to indicate it's the checked account

* Checking only the active claim address for other chains

Co-authored-by: Leandro <[email protected]>
ramirotw pushed a commit that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants