Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

2082/no success on failure #2355

Merged
merged 6 commits into from
Jan 31, 2022
Merged

2082/no success on failure #2355

merged 6 commits into from
Jan 31, 2022

Conversation

alfetopito
Copy link
Contributor

@alfetopito alfetopito commented Jan 28, 2022

Summary

Closes #2082

No success on failure (😆)

Screen Shot 2022-01-28 at 15 18 37

When the claim tx fail, show instead a failure screen

Screen.Recording.2022-01-28.at.15.03.32.mov

User the can go back to a step before and try to do it again.

As a bonus, successful claims also have a go back button because there was no other way back than to change the account and try it again.

To Test

  1. Either free or paid claims, proceed until you get the tx request in your wallet
  2. Make the tx fail but inserting half the gas limit provided (e.g.: if you get 160000 replace it with 80000)
Screen.Recording.2022-01-28.at.15.13.21.mov
  1. Submit the tx
  • The tx will fail and you will lose the gas, but not the investments if any
  • The UI will show you a failure screen and give you the option to go back
  1. Click on go back and try to execute again
  2. This time do not edit the tx parameters
  • Once the tx is executed, you'll see the success screen

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

Hey @alfetopito , nicely done!

The only one issue I'd like to mention here is the design of the 'Go back' button: it is different than all the rest 'Go back' buttons on the form. So it would be nice to make them the same:
New ones:
dark
in black

Already implemented ones:
like here
image

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure handling works very nice.

Only concerned is the back button on success

@anxolin
Copy link
Contributor

anxolin commented Jan 31, 2022

Merging to consolidate the RC. The concerned i had was addressed in #2358.
@biocom, maybe evaluate if we want to review the style comments from Elena or if its fine

@anxolin anxolin merged commit 954d790 into develop Jan 31, 2022
@alfetopito alfetopito deleted the 2082/no-success-on-failure branch January 31, 2022 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Claim: 'Claimed!' message is displayed when a transaction fails
3 participants