Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Fix token display in dark/light mode for transactions. #2386

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Fix token display in dark/light mode for transactions. #2386

merged 1 commit into from
Feb 4, 2022

Conversation

fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Feb 3, 2022 •
edited
Loading

Summary

  • Fixes [1.10] GNO icon is not visible in the dark mode #1913
  • Instead of detecting colors it simply applies a lighter background to the token image, in dark mode.
  • This solution has been chosen because I believe it provides more predictable results (instead of inverting images) and keeps the token images at its original resemblance.

Screen Shot 2022-02-03 at 13 12 33

Screen Shot 2022-02-03 at 13 12 21

@fairlighteth fairlighteth requested review from a team February 3, 2022 13:48
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh elena-zh mentioned this pull request Feb 3, 2022
Open
elena-zh
elena-zh approved these changes Feb 3, 2022
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@biocom , great solution!
I opened another enhancement to show tokens' icons in token lists in the same manner #2387 (can be address in the future).

anxolin
anxolin approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ❤️

Thanks Elena also for opening a new for the other tokens 👌

@fairlighteth fairlighteth merged commit 94245c5 into develop Feb 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2022
@alfetopito alfetopito deleted the fix-token-darkmode-color branch February 4, 2022 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@anxolin anxolin anxolin approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.10] GNO icon is not visible in the dark mode
4 participants
@fairlighteth @alfetopito @anxolin @elena-zh