Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Updated gas estimation for gchain #2391

Merged
merged 4 commits into from
Feb 7, 2022
Merged

Updated gas estimation for gchain #2391

merged 4 commits into from
Feb 7, 2022

Conversation

alfetopito
Copy link
Contributor

Summary

Closes #2389

Gas estimation for gchain now uses proper values

Screen Shot 2022-02-03 at 16 04 11

To Test

  1. Try to use 100% of xDAI investment and not have enough to claim. Not easy!
  2. I managed to do so with these 2 accounts: The account to claim on gchain 0xcbeAd39cC0b43d14c2f240c25f3D5234bbDFF10c and the account to claim with 0x2F144ff590C94871f118583E61fdDd06b98120e4 (PK in on the spreadsheet)
  • You should see the low xDAI warning

@alfetopito alfetopito self-assigned this Feb 4, 2022
@alfetopito alfetopito requested review from a team February 4, 2022 00:09
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alfetopito , changes LGTM!
As a nitpick I can say that sometimes gas estimation might be a bit optimistic and a user will not wee the warning message, however, will not be able to sign the TX due to insuff. funds error, but the issue is reproducible to every network.
no
unsuff

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe increase the numbers a bit just in case? (if elena managed to get the error in MM)

Also, hardcoded doesn't sound too good. Maybe u can consider what I suggested below

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

CLA Assistant Lite:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Leandro seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger the CLA Action by commenting recheckcla in this Pull Request

@alfetopito
Copy link
Contributor Author

@elena-zh and @anxolin I've bumped the gas estimation 20% over the estimated amount

Also fetching it from Blockscout's gas endpoint

@alfetopito alfetopito changed the title Using hardcoded gas values for gchain Updated gas estimation for gchain Feb 6, 2022
@elena-zh
Copy link

elena-zh commented Feb 7, 2022

Seems that I can't retest it as investment options are no longer available (2 weeks have passed).

@nenadV91 nenadV91 merged commit af1a7c6 into develop Feb 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2022
@nenadV91
Copy link
Contributor

nenadV91 commented Feb 7, 2022

Merging this to cherry-pick into hotfix branch, should be reviewed after!

@alfetopito alfetopito deleted the 2389/gas-on-gchain branch February 7, 2022 14:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.10] Change gas recommendations for GC when claim xDAI
4 participants