Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Show banner if the user has claimed already #2393

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

nenadV91
Copy link
Contributor

@nenadV91 nenadV91 commented Feb 4, 2022

Summary

Show banner message if the user has no more available claims but has already claimed some claims
Screenshot from 2022-02-04 14-21-57

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@nenadV91 nenadV91 requested review from a team February 4, 2022 13:28
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

elena-zh commented Feb 4, 2022

Hey @nenadV91 , great!
However, some cases:

  1. As a not connected user, I see that an account has available tokens to claim in the GC, but the account has already claimed. However, reported in [1.10] Message about available claims appear when a user has already claimed #2382 , and might need a more complex solution to solve this...
    image
    image

  2. I'd rewrite the message to make it simpler. Something like 'This account has already claimed vCOW tokens!' or so.

  3. As for the colors, I think we have a lot of different ones on the Claim form for warning/info messages. So as a proposal, I'd use the same color for the banner as we do for the warning on the last claim page. @biocom , WDYT?
    image
    image
    image

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it does communicate the message to the user in the banner, the rest of the page says something different:

Screen Shot 2022-02-04 at 08 13 59

What about hiding all that (0 vCOW and the text)?
Or maybe load the vCOW balance for this account and say something like:

This account has now:
[cow logo] XXX vCOW

Welcome to Cowmunity etc...

Also the button at the bottom has no relevant action and should just be removed

@nenadV91
Copy link
Contributor Author

nenadV91 commented Feb 8, 2022

@alfetopito we said yesterday on sync that we will just show the banner for this PR and then probably add your suggested changes as a following PR.

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@nenadV91 nenadV91 merged commit a57279f into develop Feb 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2022
@alfetopito alfetopito deleted the is-claimed-banner-feature branch February 9, 2022 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants