2382/already claimed #2394
2382/already claimed #2394
Conversation
|
CLA Assistant Lite: I have read the CLA Document and I hereby sign the CLA Leandro seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
|
|
Hey @alfetopito , great! Also, I noticed that the app still shows available claims banner until I switch to another network and check that the claims have already done there. |
That's odd, I'll try to reproduce it.
Correct. We can only tell if a claim is no longer available if you access the network where you are supposed to have a claim. |
Hey @alfetopito , I can reproduce the issue in this PR only. I test in Win10+Chtome. But I'm able to reproduce it in Firefox and Brave as well. |
alfetopito
force-pushed
the
2382/already-claimed
branch
from
f8c8e3f to
c01a64e
Compare
|
@elena-zh looking more closely I found several issues with this PR (😳) They should all be fixed now and I think the issue you were facing was a mistake causing it to go into an infinite loop. Hopefully all that is fixed now 🤞 |
- Updated state to add new dimension to claim info: account Otherwise when checking a different account the state would be preserved and would lead to bad data - Refactored Updater to fix dependency on obj causing it to being stuck in a re-render loop - Fixed logic that compared different types using `===` instead of `==` - Fixed logic that was causing claim to be displayed when there were no claims
alfetopito
force-pushed
the
2382/already-claimed
branch
from
c01a64e to
630bf4f
Compare
Summary
Closes #2382
Once you load the network you have claims on, and all claims are gone, remove the banner on other networks
Screen.Recording.2022-02-04.at.16.01.00.mov
To Test