Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Enhance messages for Affiliate program #2414

Merged
merged 7 commits into from
Feb 17, 2022
Merged

Enhance messages for Affiliate program #2414

merged 7 commits into from
Feb 17, 2022

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented Feb 10, 2022 •
edited
Loading

Summary

Fixes #2409

  • Remove 'already traded' message.

  • Enhance all the rest messages.

    To Test

  1. Open the page Profile

@alongoni alongoni added Enhancement New feature or request Protofire Handled by Protofire development team Medium Severity indicator. It causes some undesirable behavior, but the system is still functional labels Feb 10, 2022
@alongoni alongoni self-assigned this Feb 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2022 •
edited
Loading

CLA Assistant Lite:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger the CLA Action by commenting recheckcla in this Pull Request

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@alongoni alongoni marked this pull request as ready for review February 11, 2022 15:35
@elena-zh
Copy link

Hey Agustin! Seems that there is an excessive message in these warnings:
image
image
image

Could you please fix it?

All the rest changes LGTM.

@alongoni
Copy link
Contributor Author

Thanks @elena-zh, can you test it again?

elena-zh
elena-zh approved these changes Feb 15, 2022
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alongoni , changes LGTM.
But let other team members take a look at these changes.
Maybe anyone might have an idea how to make these messages even shorter 😉

alfetopito
alfetopito approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one minor comment below, looks ok to me.
I'll circulate this with the team to get more input.

@alongoni @alfetopito
wording
e664334 
Co-authored-by: Leandro Boscariol <[email protected]>
@alongoni alongoni added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Feb 17, 2022
@mergify mergify bot merged commit 7319d6c into develop Feb 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2022
@alfetopito alfetopito deleted the 2409-enhance-messages-affiliate-program branch February 17, 2022 22:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@anxolin anxolin anxolin approved these changes

@elena-zh elena-zh elena-zh approved these changes

@ramirotw ramirotw Awaiting requested review from ramirotw

Assignees

@alongoni alongoni

Labels
Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds Enhancement New feature or request Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Protofire Handled by Protofire development team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance messages for Affiliate program
5 participants
@alongoni @elena-zh @alfetopito @anxolin @ramirotw