This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Fix avilable claims issue on rinkeby #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
alfetopito
reviewed
Feb 14, 2022
| @@ -53,7 +69,7 @@ export function ClaimSummaryView({ showClaimText, totalAvailableText, totalAvail | |||
| </Trans> | |||
| </ClaimSummaryTitle> | |||
| )} | |||
| {totalAvailableAmount && ( | |||
| {totalAvailableAmount && activeClaimAccount && ( | |||
There was a problem hiding this comment.
I don't think you need this here, since the amount is only used as a flag.
You can control this in the parent component, as you already do.
I think it'll work the same without this extra parameter. Doesn't it?
There was a problem hiding this comment.
I think we need this also because the totalAvailableAmount is now CurrencyAmount object by default and this happens otherwise
nenadV91
commented
Feb 17, 2022
| if (!hasClaimSummary) return null | ||
| if (!hasClaimSummary || !vCow) return null | ||
|
|
||
| let totalAvailableAmount: CurrencyAmount<Token> | undefined = CurrencyAmount.fromRawAmount(vCow, JSBI.BigInt(0)) |
There was a problem hiding this comment.
This is now set to CurrencyAmount object by default because we want to show zero in this case and so that formatSmartLocaleAware and formatMax work
alfetopito
approved these changes
Feb 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2419
This scenario happens when there are no claimed or available claims but there is vCow balance, which means that user somehow has vCow balance but he didn't claim anything. So this probably shouldn't happen on Mainet or Gnosis Chain but happens on Rinkeby on accounts where you have vCow tokens from previous vCow contract deployments.