-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
CLA Assistant Lite: I have read the CLA Document and I hereby sign the CLA You can retrigger the CLA Action by commenting recheckcla in this Pull Request |
|
Hey @alongoni , great! A couple of issues I have faced: In order to reproduce this issue, please expand Swap form as much as you can (specify a token pair with amounts, add recipient to the trade, etc). Then reduce the screen to the tablet mode and open the menu
Thanks! |
Hey @elena-zh
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great on FF to me!
Looping @biocom for another CSS pair of eyes
Hey @alongoni , I'm also no longer possible to reproduce the issue with a double scroll. Scrollbar in FF looks' good to me now! However, I have noticed another issue: when open a token list, and it is loading, you will see this (see the screenshot) for 2-3 sec Could we fix this? |
@@ -30,7 +30,7 @@ export const AutoColumn = styled(AutoColumnUni)` | |||
|
|||
export const MobileWrapper = styled(AutoColumn)` | |||
${({ theme }) => theme.mediaWidth.upToSmall` | |||
isplay: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually in mobile devices we can see the common tokens row.
What should we do with this?
If we fix this typo with display: none;
, the common token list will disappear:
I believe we can keep it.
cc @elena-zh @alfetopito @biocom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave the token list as is. The horizontal scroller is expected and is only shown for resolutions smaller than desktop. On desktop they are just stacked. But on smaller devices, horizontal real estate is more precious. Further more, on actual touch devices (mobile/tablet) the scrollbar is not shown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Fixes #1145

Confirmation Modal:
Select a token modal:


Before/After
Styles on main scrollbar:


Before:
After:
To Test