Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Fix 404 for OPYN_LIST url (their file name changed) #2481

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

fadomire
Copy link
Contributor

Summary

there is a 404 when requesting the opyn-tokenlist

they changed their filename in this commit:
opynfinance/opyn-tokenlist@409fdc8

This PR update the previous url with the new one

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@fadomire
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good:

Screen Shot 2022-02-22 at 16 29 04
Screen Shot 2022-02-22 at 16 28 44

I mean, we have to work a bit on the contrast for dark mode, but it works as expected :)

@alfetopito
Copy link
Contributor

Thanks for the contribution by the way :)

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! it works, however, why Opyn list don't include the image of the token?

image

Can you make sure they change their list to include logoURI? Check out this example https://raw.githubusercontent.com/SetProtocol/uniswap-tokenlist/main/set.tokenlist.json

@anxolin anxolin merged commit 55ffce3 into gnosis:develop Feb 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2022
@fadomire fadomire deleted the patch-1 branch February 23, 2022 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants