This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
2473/cancel claim issue #2485
Merged
2473/cancel claim issue #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
nenadV91
force-pushed
the
2473/cancel-claim-issue
branch
from
62bc58d to
d902e5f
Compare
|
Hey @nenadV91 , great changes! One tiny nitpick: when a transaction is cancelled, we get a pop-up notification with a green checkmark on it, so it might seem that the Tx is successful. Also, just FYI, I have created a separate issue for the case when a transaction is executed, but it hangs in the 'Cancelling' pending state #2486 |
W3stside
approved these changes
Feb 22, 2022
anxolin
approved these changes
Feb 23, 2022
| @@ -62,7 +62,7 @@ import useIsMounted from 'hooks/useIsMounted' | |||
| import { ChainId } from '@uniswap/sdk' | |||
| import { ClaimInfo } from 'state/claim/reducer' | |||
|
|
|||
| const CLAIMS_REPO_BRANCH = 'gip-13' | |||
There was a problem hiding this comment.
Very careful with merging this. If this gets to production we will have some troubles
This reverts commit d902e5f.
|
@elena-zh Since there is a separate issue for pop-up notification I am merging this one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2473
Todo