-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
CLA Assistant Lite: I have read the CLA Document and I hereby sign the CLA You can retrigger the CLA Action by commenting recheckcla in this Pull Request |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for checking this. My comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just make sure Michel's comments are accounted for and I think it's good to go
Changes LGTM. But again, we have #1550 issue on the board that is related to footer elements displaying, so the issue might be fixed there. @alfetopito , @biocom , WDYT? |
@alongoni , looks much-much better. Can we fix it somehow? |
Yes, I saw it. But I think this behavior is ok since in mobile we don't have a :hover state. So in mobile the text has by default the max contrast between the text color and the background. Maybe we can leave it as it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved then!
Summary
Fixes #1276 and #1550
The layout has changed a bit. Some small resolutions now have less padding on top but the scroll not appear.


Before (on production with scroll):
After (on this PR without scroll):


To Test
Swap