Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

[2506] Sync BE errors with FE #2507

Merged
merged 6 commits into from
Mar 2, 2022
Merged

Conversation

W3stside
Copy link
Contributor

@W3stside W3stside commented Feb 28, 2022

Summary

Closes #2506 - syncs latest errors and descriptions with FE for appropriate handling in the UI

Screenshots
image

To Test

Connect SC wallet
Set native as buy token
Input an amt as sell
Error should appear

@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@W3stside W3stside requested review from a team February 28, 2022 16:10
@W3stside W3stside marked this pull request as ready for review February 28, 2022 16:10
@elena-zh
Copy link

elena-zh commented Mar 1, 2022

Changes LGTM (according to the issue description)

However, I wonder why we show different messages on the FE from what I see in the files. As an example, 'Fees exceed from amount'
image

Btw, there was a task to change this message on FE #1957

@W3stside
Copy link
Contributor Author

W3stside commented Mar 1, 2022

Changes LGTM (according to the issue description)

However, I wonder why we show different messages on the FE from what I see in the files. As an example, 'Fees exceed from amount' image

Btw, there was a task to change this message on FE #1957

it's normal, its just the default description

@fairlighteth
Copy link
Contributor

On @elena-zh 's point, in my view the current text 'Fees exceed from amount' doesn't read natural. The FeeExceedsFrom text, reads more natural and provides better context. It's longer, but for that we need to adjust the UI.

@W3stside W3stside changed the base branch from develop to release/1.11-rc-0 March 2, 2022 11:54
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, but added a comment

Co-authored-by: Anxo Rodriguez <[email protected]>
@W3stside W3stside merged commit f4e511f into release/1.11-rc-0 Mar 2, 2022
@W3stside W3stside deleted the sync-be-fe-errors branch March 2, 2022 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync BE/FE errors
4 participants