[Technical Debt] top level console override (replacement for 2532)

[W3stside]

Potential replacement of #2532

Part of #1887

Testing

check PRaul for logs

[github-actions]

• 🔭 GP Swap: CoW Protocol v2 Swap UI

[alfetopito]

Definitely much cleaner.

Is there a way to override the behaviour if we ever want to, though?

Let's say there are cases where we still might want to log something. Shouldn't we still be able to?

[W3stside]

Definitely much cleaner.

Is there a way to override the behaviour if we ever want to, though?

Let's say there are cases where we still might want to log something. Shouldn't we still be able to?

... that's a good point, let me do sth

[W3stside]

also I've added console.error as well to this. do we want this ux?

[alfetopito]

Definitely much cleaner.
Is there a way to override the behaviour if we ever want to, though?
Let's say there are cases where we still might want to log something. Shouldn't we still be able to?

... that's a good point, let me do sth

You haven't pushed yet, have you?

Assuming not, I would suggest and optional force parameter that ignores the environment when set:

console.log('shit, this should be visible, ALWAYS!!', force=true)
// OR
console.force.log('same thing...')

The second option would be a proxy/wrapper that invokes regular logging fns.

WDYT?

[W3stside]

Definitely much cleaner.
Is there a way to override the behaviour if we ever want to, though?
Let's say there are cases where we still might want to log something. Shouldn't we still be able to?

... that's a good point, let me do sth

You haven't pushed yet, have you?

Assuming not, I would suggest and optional force parameter that ignores the environment when set:

console.log('shit, this should be visible, ALWAYS!!', force=true)
// OR
console.force.log('same thing...')

The second option would be a proxy/wrapper that invokes regular logging fns.

WDYT?

i like the second

[W3stside]

@alfetopito 713872c

[alfetopito]

Noice!