Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Updated abis for vCow #2562

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Updated abis for vCow #2562

merged 2 commits into from
Mar 21, 2022

Conversation

nenadV91
Copy link
Contributor

Summary

This PR is part of the previous #2552 PR now separated into this PR and another one for hooks, for the sake of easier review.

  • adds swappableBalanceOf and balanceOf methods on the vCow abi
  • separates scripts to build custom Cowswap and Uniswap abis
  • adds script to append Uniswap export line to the end of generated types/index.ts file

@nenadV91 nenadV91 requested a review from a team March 18, 2022 14:24
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

alfetopito
alfetopito approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

W3stside
W3stside approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@W3stside W3stside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, much easier to read!

@nenadV91
Added hook to fetch vCow data and vCow token (#2563)
4d52bd7 
* Added hook to fetch vCow data and vCow token

* Added some PR changes
@nenadV91 nenadV91 mentioned this pull request Mar 19, 2022
Closed
2 tasks
@W3stside
Copy link
Contributor

let's merge this @nenadV91 anything blocking?

@nenadV91 nenadV91 merged commit 54406f9 into develop Mar 21, 2022
@nenadV91
Copy link
Contributor Author

@W3stside Merged 👍

@nenadV91 nenadV91 mentioned this pull request Mar 21, 2022
Merged
@alfetopito alfetopito deleted the swap-vCow-abis branch March 21, 2022 22:55
anxolin
anxolin reviewed Mar 22, 2022
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see you broke it down and move this to another PR.

@W3stside W3stside mentioned this pull request Mar 22, 2022
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin left review comments

@alfetopito alfetopito alfetopito approved these changes

@W3stside W3stside W3stside approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nenadV91 @W3stside @alfetopito @anxolin