Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Updated profile page and addes shimmer effect #2581

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

nenadV91
Copy link
Contributor

@nenadV91 nenadV91 commented Mar 23, 2022

Summary

  • shows balance cards by default
  • shows shimmer effect on loading and when the convert is pending
  • fixes issue with missing images in activity modal

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@nenadV91 nenadV91 force-pushed the convert-vcow-updates-1 branch from 0c76c12 to f455963 Compare March 23, 2022 23:01
@fairlighteth
Copy link
Contributor

@nenadV91 Looks good! Tested:

  • Converting vCOW to COW -> Shows nice shimmer effect and - for the vested balance (while in progress). Also nice that it shimmers while loading the balance (on page load)!
  • Once I had COW balance, I sent out my full COW balance to another account. This resulted in 0 COW balance and was updated without requiring a page refresh. Also the 0 COW balance card remains visible at all times.

One tiny issue I spotted is that the vCOW token image seems wrong. This is outside this PR as I think there might be an issue somewhere:
Screen Shot 2022-03-24 at 09 41 49

Copy link
Contributor

@fairlighteth fairlighteth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the minor note about the vCOW token image seemingly being incorrect.

@nenadV91 nenadV91 merged commit 39b3d74 into release/1.12.0 Mar 24, 2022
@elena-zh
Copy link

Looks good to me.
In addition to @fairlighteth comment I'd add that it would be nice to show zeros in the balance tooltip to a not connected user
image

Also, it would be nice to show an amount or 0 when converting
image

@alfetopito alfetopito deleted the convert-vcow-updates-1 branch March 24, 2022 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants