This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Improve loading #2595
Merged
Improve loading #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @anxolin , could you please help to generate the PR-preview link? |
|
fix the history please |
W3stside
approved these changes
Mar 28, 2022
|
@elena-zh I will merge to consolidate. We will generate a link including this and the latest other things so u can double check it there. Here it didn't work the PRaul |
|
Hey @anxolin , I have verified this PR in the release PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add loading a blinking effect while loading for the "Loading ..." message.
After adding Lazy-loading and code-splitting we were showing this message. This PR is just a small improvement on handing the app boot.
Mar-27-2022.15-06-21.mp4
Mar-27-2022.15-08-40.mp4
To Test
Just throttle the internet a little bit
Observe loading message is now loading