Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Update FAQ to reflect Token Launch (#2540) #2603

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Update FAQ to reflect Token Launch (#2540) #2603

merged 3 commits into from
Mar 29, 2022

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Mar 29, 2022 •
edited
Loading

Apply this PR #2540 as a cherry-pick

@avsavsavs @lint-action @anxolin
Update FAQ to reflect Token Launch (#2540)
3749fa6 
* Update FAQ to reflect Token Launch

This PR pushes a new content section from lines 559 - 627 that addresses questions related to the token launch. I have tried format everything as good as I possibly know/can, apologies if it needs to be reworked. 

Questions are: 
562 - Does CowSwap Have a token? 
580 - Is there a proposal to make vCOW transferrable?
585 - what is the purspose of the COW tokens?
605 - what was the criteria for the token airdrop?

* Fix code style issues with Prettier

* Fix building error

* Add space

* Update index.tsx

* Fix code style issues with Prettier

* Add punctuantions

Co-authored-by: Lint Action <[email protected]>
Co-authored-by: Anxo Rodriguez <[email protected]>
@anxolin anxolin marked this pull request as ready for review March 29, 2022 09:00
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

elena-zh commented Mar 29, 2022 •
edited
Loading

Changes LGTM!
But still 1 period is missing in the 'What was the criteria for the token airdrop?' section
image

@elena-zh
Copy link

elena-zh commented Mar 29, 2022 •
edited
Loading

Maybe it was mentioned before, but I'd make these categories' names in bold:
image
and these components' names

image

nenadV91
nenadV91 reviewed Mar 29, 2022
View reviewed changes
src/custom/pages/Faq/index.tsx Outdated
13974427) or Gnosis Chain (block 20024195). They were eligible for holding GNO on Mainnet and/or
GnosisChain, and for running GBC validators. In addition, all the following LP token holders were accounted
for: Balancer v2 (mainnet), Uniswap v3 (mainnet), Honeyswap (gnosischain), Symetric (gnosischain), Sushiswap
(gnosischain), Elk (gnosischain), Swapr (Gnosischain).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use lower case on the last (Gnosischain). for consistency 😄

nenadV91
nenadV91 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@nenadV91 nenadV91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the mentioned comments and build issue, looks good to me 👍

@anxolin
Copy link
Contributor Author

anxolin commented Mar 29, 2022

Done
image

@anxolin anxolin requested a review from elena-zh March 29, 2022 10:33
@anxolin
Copy link
Contributor Author

anxolin commented Mar 29, 2022

Merging, to prepare release to not delay it more.

Any new comment, we can apply to the one @fairlighteth is preparing

@anxolin anxolin merged commit 879e9ba into hotfix/1.12.3 Mar 29, 2022
@elena-zh
Copy link

@anxolin , nice!
I have asked @fairlighteth to fix this in his PR:

in this paragraph we have different writing of networks names. Some are started with the capital letter, some with lowercase ones. Gnosis chain is spelled somewhere together, somewhere separately. I think, we should be consistent with networks spelling
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@W3stside W3stside W3stside approved these changes

@nenadV91 nenadV91 nenadV91 approved these changes

@elena-zh elena-zh Awaiting requested review from elena-zh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anxolin @elena-zh @W3stside @nenadV91 @avsavsavs