Fix module entrypoints #121
Conversation
| @@ -87,8 +88,5 @@ | |||
| "@openzeppelin/contracts": "^4.8.1", | |||
| "@openzeppelin/contracts-upgradeable": "^4.8.1", | |||
| "ethers": "^5.7.1" | |||
| }, | |||
| "peerDependencies": { | |||
| "ethers": "^5.7.1" | |||
There was a problem hiding this comment.
I remember that when using the zodiac package in another project, we got some problems when we did not specify the correct hardhat and ethers versions as peerDependencies.
I think it was that if you added it to a project that used a hardhat or ethers version older, then once specified here, it would break (if I remember correctly, it was because some of the functions take hre from hardhat as input and will not work with older versions, I can not quit remembering what was the case with ethers).
Have you tested using it from other packages without the peerDependencies?
There was a problem hiding this comment.
I've tested with a local install now and this seems to work fine. I believe this issue might have been resolved when we got rid of the hardhat dependency.
I found and fixed another issue when consumed within CRA, though. (Should really have done the local install testing earlier, would have saved us some PRs. 😅)
This fixes the paths to package's entrypoint / index files.