-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deploy contracts on the latest gno #479
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also remove r/demo/users from all contract? #465 (comment)
You can paste a commit link to Manfred's comment aftetwards.
For now, unfortunately no. Those two tokens(specifically foo20) kinda works like de-facto for current gno, so I would say we better change it once they change. |
As long as it works fine with addresses, it's fine. Just remove. |
@dongwon8247 understood. Removing it is huge change (there are bunch of tests relying on that type). I'll make a new PR about it. |
Tested with...
Fixed
Added
info.mk
works like .env for makefiledeploy.mk
does only deploy contracttest.mk
does contain bunch of gnokey commands to make and send transaction to contract.