Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deploy contracts on the latest gno #479

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Jan 21, 2025

Tested with...

  1. gnoswap main branch, latest commit: 95f0031
  2. gnolang master branch, latest commit: gnolang/gno@8702da9

Fixed

  1. remove all unused imports ( + also lint has been applied )
  2. test file name typo
  3. bump gas used and fee (due to changes made by latest gno)

Added

  1. info.mk works like .env for makefile
  2. deploy.mk does only deploy contract
  3. test.mk does contain bunch of gnokey commands to make and send transaction to contract.

@r3v4s r3v4s self-assigned this Jan 21, 2025
Copy link
Member

@dongwon8247 dongwon8247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove r/demo/users from all contract? #465 (comment)

You can paste a commit link to Manfred's comment aftetwards.

@r3v4s
Copy link
Member Author

r3v4s commented Jan 21, 2025

Can you also remove r/demo/users from all contract? #465 (comment)

You can paste a commit link to Manfred's comment aftetwards.

For now, unfortunately no.
foo20 and wugnot are still using users.AddressOrName rather than std.Address.

Those two tokens(specifically foo20) kinda works like de-facto for current gno, so I would say we better change it once they change.

Any ideas?? (@onlyhyde @notJoon )

@dongwon8247
Copy link
Member

As long as it works fine with addresses, it's fine. Just remove.

@r3v4s
Copy link
Member Author

r3v4s commented Jan 21, 2025

@dongwon8247 understood. Removing it is huge change (there are bunch of tests relying on that type). I'll make a new PR about it.

@dongwon8247 dongwon8247 changed the title fix: deploy contract on lates gnoland fix: deploy contracts on the latest gno Jan 21, 2025
@dongwon8247 dongwon8247 merged commit 9402d11 into main Jan 21, 2025
2 checks passed
@dongwon8247 dongwon8247 deleted the fix/deploy-and-test branch January 21, 2025 08:51
moul pushed a commit that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants