-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Split Launchpad
Contract into p
/r
Pacakges
#485
base: main
Are you sure you want to change the base?
Conversation
…into launchpad-pr
I am currently working on separating the launchpad contract into p and r packages based on their states. As you mentioned earlier, I've structured the two packages to have identical names and added files as needed. The goal of this refactor is:
Although this PR still in WIP, could you please check if this is the structure you had in mind? Thank you. Please note this: there is duplicate code since I have only migrated the types and pure functions, and have not yet refined cc: @dongwon8247 |
Quality Gate passedIssues Measures |
if you think that the r/launchpad/v2 will be able to reuse most of the p/launchpad, then it could make sense to make this split, but if not, it's probably better to keep most of the logic in a single r/launchpad. |
Description
WIP