Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Split Launchpad Contract into p/r Pacakges #485

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Jan 22, 2025

Description

WIP

@notJoon notJoon self-assigned this Jan 22, 2025
@notJoon
Copy link
Member Author

notJoon commented Jan 24, 2025

@moul

I am currently working on separating the launchpad contract into p and r packages based on their states. As you mentioned earlier, I've structured the two packages to have identical names and added files as needed.

The goal of this refactor is:

  1. re-structuring to make it easier to apply upgradable realm patterns (separation of p and r based on their status)
  2. reduce dependencies
  3. enhance code reusability and maintainability

Although this PR still in WIP, could you please check if this is the structure you had in mind? Thank you.

Please note this: there is duplicate code since I have only migrated the types and pure functions, and have not yet refined r/launchpad directory.

cc: @dongwon8247

@moul
Copy link

moul commented Jan 26, 2025

if you think that the r/launchpad/v2 will be able to reuse most of the p/launchpad, then it could make sense to make this split, but if not, it's probably better to keep most of the logic in a single r/launchpad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants