Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: In realm code, use txlink.URL #138

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

jefft0
Copy link
Contributor

@jefft0 jefft0 commented Nov 14, 2024

PR gnolang/gno#2887 introduced the helper function txlink.URL to format the URL "help" screen for the gnokey command. It also updated r/demo/boards to use it. In dSocial, we have a similar need. This PR updates the realm code to use txlink.URL . As an advantage, this is future proofing against changes to the "help" screen, as happened a few weeks ago in PR gnolang/gno#2876 . Without using txlink.URL, those are breaking changes.

@jefft0 jefft0 requested a review from D4ryl00 November 14, 2024 16:56
Copy link
Contributor

@D4ryl00 D4ryl00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just please check comments.

realm/post.gno Show resolved Hide resolved
"&userPostsAddr=" + post.userPosts.userAddr.String() +
"&threadid=" + post.threadID.String() +
"&postid=" + post.id.String() +
"&body.type=textarea"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here.

realm/userposts.gno Show resolved Hide resolved
@jefft0 jefft0 merged commit 3c96e17 into gnoverse:main Nov 15, 2024
1 check passed
@jefft0 jefft0 deleted the fix/use-txlink.URL-in-realm branch November 15, 2024 07:52
Copy link

🎉 This PR is included in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants