Update/config updates #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with local and added new middleware specifically for firebase
gnurgeldiyev
reviewed
Apr 1, 2023
Comment on lines
+30
to
+40
| // script: [ | ||
| // { | ||
| // src: `https://www.googletagmanager.com/gtag/js?id=${google_analytics}`, | ||
| // async: true, | ||
| // }, | ||
| // { | ||
| // innerHTML: `window.dataLayer = window.dataLayer || [];function gtag(){window.dataLayer.push(arguments);}gtag('js', new Date());gtag('config', '${google_analytics}');`, | ||
| // type: "text/javascript", | ||
| // defer: true, | ||
| // }, | ||
| // ], |
There was a problem hiding this comment.
@bakmyradov Why did you comment out the google analytics here?
There was a problem hiding this comment.
I didn't have the correct credentials and it was giving an error that's why I left it commented.
gnurgeldiyev
reviewed
Apr 1, 2023
|
|
||
| // a security middleware that handles several kinds of attacks in the HTTP/HTTPS protocols | ||
| app.use(helmet()) | ||
| // app.use(helmet()); |
There was a problem hiding this comment.
@bakmyradov any reason why did you comment out helmet?
There was a problem hiding this comment.
When dealing with package updating there was an error in the helmet package. I apologize I forgot to uncomment it after resolving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated packages and google firebase authentication added.