Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds benchmarks for nallocx, calloc, alloc, alloc_excess, ralloc, ralloc_excess #26

Merged
merged 15 commits into from
Nov 27, 2017

Conversation

gnzlbg
Copy link
Owner

@gnzlbg gnzlbg commented Nov 23, 2017

No description provided.

@gnzlbg
Copy link
Owner Author

gnzlbg commented Nov 23, 2017

@alexcrichton I am adding these benchmarks to jemallocator even though they only use jemalloc-sys, I hope that is ok.

@gnzlbg gnzlbg changed the title Adds benchmarks for nallocx and calloc Adds benchmarks for nallocx, calloc, alloc, alloc_excess Nov 23, 2017
@gnzlbg gnzlbg changed the title Adds benchmarks for nallocx, calloc, alloc, alloc_excess Adds benchmarks for nallocx, calloc, alloc, alloc_excess, ralloc, ralloc_excess Nov 23, 2017
@SimonSapin
Copy link
Contributor

Its a lot of boilerplate that I don't seem to be able to avoid because I cannot concatenate identifiers to form new identifiers in macros.

Rather than generating functions whose names are concatenated identifiers, I’ve had some success making macros generate functions in modules. So instead of ${foo}_${bar} you end up with $foo::$bar for example.

@gnzlbg
Copy link
Owner Author

gnzlbg commented Nov 23, 2017

@SimonSapin the problem I ran into was that I had the size and align as part of the test name. I would have to move them to be part of the module's name, but I don't think that is possible.

}
if !configure.exists() {
panic!("jemalloc/configure does not exist");
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be left out to a future PR?

The submodule update here I don't think shoudl be run with run which asserts success, it should just be opportunistic and should provide a better failure message unrelated to git if the git step ends up failing.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcrichton the submodule update is a mistake in this PR, i have reverted it.

I have it in a separate PR, but git add -u pulled into all my other PRs making i686-apple builds fail... Sorry about that.

@alexcrichton alexcrichton merged commit 56559c7 into gnzlbg:master Nov 27, 2017
BusyJay added a commit to BusyJay/jemallocator that referenced this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants