-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds benchmarks for nallocx, calloc, alloc, alloc_excess, ralloc, ralloc_excess #26
Conversation
@alexcrichton I am adding these benchmarks to jemallocator even though they only use |
Rather than generating functions whose names are concatenated identifiers, I’ve had some success making macros generate functions in modules. So instead of |
@SimonSapin the problem I ran into was that I had the |
jemalloc-sys/build.rs
Outdated
} | ||
if !configure.exists() { | ||
panic!("jemalloc/configure does not exist"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be left out to a future PR?
The submodule update here I don't think shoudl be run with run
which asserts success, it should just be opportunistic and should provide a better failure message unrelated to git if the git step ends up failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexcrichton the submodule update is a mistake in this PR, i have reverted it.
I have it in a separate PR, but git add -u
pulled into all my other PRs making i686-apple
builds fail... Sorry about that.
Signed-off-by: Jay Lee <[email protected]>
No description provided.