Fork wcharczuk/go-chart into repo under chartdraw package
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported from commit: c9c904215494e8db2f55863b1855bb0a09ef58d8 This was drafted earlier as a first step to unifying and simplifying the API. Because `wcharczuk/go-chart` has been archived, it makes sense to go ahead and move forward with combining the code together.
…time is empty and unittest
This commit updates the test cases for the SVG rendering changes from the parent project (after a fix for when the transparent / `none` being rendered correctly). In addition this removes testutil/helpers and instead just using testify
Logger is relatively under utilized, so I want to remove it to help simplify for now.
Adds unit tests for the mathutil code, and brings in a couple fixes found from testing.
This commit removes a few more unused implementations, fixes spelling errors, and other warnings.
jentfoo
force-pushed
the
jent/wcharczuk_merge
branch
from
ba5ecdb to
27f141c
Compare
jentfoo
changed the title
chartdraw packagewcharczuk/go-chart into repo under chartdraw package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in the code from the
wcharczuk/go-chartdependency under this project. I was already playing with this idea because our API already needs you to be aware of this dependency and I like the idea of unifying and simplifying this separation. However with the recent archive of wcharczuk/go-chart it makes sense to go ahead and make the change to unify this code together.This PR in detail makes the following changes to the upstream
wcharczuk/go-chart:chartdrawpackage almost all contents from the upstreamwcharczuk/go-chartproject. Including the recent fix for GHSA-jq6p-6wg4-wrw8 / CVE-2024-40060mathutilsand fixed a couple additional bugs foundThis PR does not include any API changes for our library or
wcharczuk/go-chart(minus moving to ourchartdrawpackage). Those changes will come in a future PR, but will require additional thought as I want to make sure the advantages of both libraries is maintained. Feedback welcome!