Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target redirects #2146

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Target redirects #2146

merged 1 commit into from
Sep 1, 2020

Conversation

aarzilli
Copy link
Member

@aarzilli aarzilli commented Aug 22, 2020

cmd,proc,terminal,debugger: Support default file descriptor redirects

Adds features to support default file descriptor redirects for the
target process:

  1. A new command line flag '--redirect' and '-r' are added to specify file redirects for the target process
  2. New syntax is added to the 'restart' command to specify file redirects.
  3. Interactive instances will check if stdin/stdout and stderr are terminals and print a helpful error message if they aren't.

@aarzilli aarzilli force-pushed the redirect branch 8 times, most recently from 19dce9c to 26bf0af Compare August 23, 2020 11:30
@aarzilli aarzilli changed the title Target redirects [WIP] Target redirects Aug 23, 2020
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker
Copy link
Member

Just resolve conflicts.

@aarzilli aarzilli force-pushed the redirect branch 2 times, most recently from 58963a6 to 0283019 Compare September 1, 2020 17:22
Adds features to support default file descriptor redirects for the
target process:

1. A new command line flag '--redirect' and '-r' are added to specify
   file redirects for the target process
2. New syntax is added to the 'restart' command to specify file
   redirects.
3. Interactive instances will check if stdin/stdout and stderr are
   terminals and print a helpful error message if they aren't.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants