Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make oauth2 code clear. Move oauth2 provider code to their own packages/files #32148

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Make oauth2 code clear. Move oauth2 provider code to their own packages/files #32148

merged 5 commits into from
Oct 2, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 27, 2024

Fix #30266
Replace #31533

@lunny lunny added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Sep 27, 2024
@lunny lunny added this to the 1.23.0 milestone Sep 27, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 27, 2024
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 27, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Sep 27, 2024
@lunny lunny mentioned this pull request Sep 27, 2024
Open
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 30, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 30, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 1, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 1, 2024
@lunny lunny merged commit 3a4a1bf into go-gitea:main Oct 2, 2024
26 checks passed
@GiteaBot
Copy link
Contributor

GiteaBot commented Oct 2, 2024

I was unable to create a backport for 1.22. @lunny, please send one manually. 🍵

go run ./contrib/backport 32148
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 2, 2024
@lunny lunny mentioned this pull request Oct 2, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Oct 2, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 2, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
4f27d60 
* giteaofficial/main:
  Fix javascript error when an anonymous user visiting migration page (go-gitea#32144)
  Make oauth2 code clear. Move oauth2 provider code to their own packages/files (go-gitea#32148)
  Support repo license (go-gitea#24872)
  Fix the logic of finding the latest pull review commit ID (go-gitea#32139)
  Ensure `GetCSRF` doesn't return an empty token (go-gitea#32130)
  Bump minio-go to latest version (go-gitea#32156)
techknowlogick pushed a commit that referenced this pull request Oct 3, 2024
@lunny
Don't init singing keys if oauth2 provider disabled (#32177)
d86433c 
Backport #32148
@wxiaoguang
Copy link
Contributor

Regression: Gitea service panics when attempting to clone/pull #32367

@lunny lunny deleted the lunny/clean_oauth2 branch October 29, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yp05327 yp05327 yp05327 approved these changes

@Zettat123 Zettat123 Zettat123 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

loadOrCreateAsymmetricKey called when oauth2 is disabled
5 participants
@lunny @GiteaBot @wxiaoguang @Zettat123 @yp05327