Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dropzone CSS to first-party and fix background color issue #32483

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

silverwind
Copy link
Member

Instead of loading and overriding part of the third-party CSS, move it to our own file. I kept some of the !important rules because they don't match the existing selectors.

Before:

Screenshot 2024-11-12 at 19 57 05

After:

Screenshot 2024-11-12 at 19 56 03 Screenshot 2024-11-12 at 19 58 17

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 12, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 12, 2024
@silverwind silverwind changed the title Move dropzone CSS to first-party and fix color issues Move dropzone CSS to first-party and fix background color issues Nov 13, 2024
@silverwind silverwind changed the title Move dropzone CSS to first-party and fix background color issues Move dropzone CSS to first-party and fix background color issue Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/frontend size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants