Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SQL Server Dialect Name in test_all.sh, so SQL Server tests start running #269

Closed
omkar-foss opened this issue Sep 24, 2024 · 0 comments · Fixed by #270
Closed

Fix SQL Server Dialect Name in test_all.sh, so SQL Server tests start running #269

omkar-foss opened this issue Sep 24, 2024 · 0 comments · Fixed by #270
Assignees
@jinzhu

Comments

@omkar-foss
Copy link
Contributor

GORM Playground Link

I'm able to reproduce this issue on my local and will be raising a PR for this, so not including a Playground link here.

Description

Currently mssql is specified in test_all.sh (here) instead of sqlserver, due to which when running tests for SQL Server the default case here is invoked instead of invoking the correct case for SQL Server here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinzhu jinzhu

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jinzhu @omkar-foss