Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convenient Query string (SetQueryString) support for Request #11

Closed
jeevatkm opened this issue Oct 7, 2015 · 1 comment
Closed

Convenient Query string (SetQueryString) support for Request #11

jeevatkm opened this issue Oct 7, 2015 · 1 comment
Assignees
@jeevatkm
Labels
enhancement
Milestone
v0.3 Milestone

Comments

@jeevatkm
Copy link
Member

jeevatkm commented Oct 7, 2015

Currently go-resty supports query string via SetQueryParam and SetQueryParams at Client and Request. However I believe in-addition to those methods. It would be better to have more comfortable experience with SetQueryString in the Request level.

resp1, err1 := resty.R().
            SetQueryString("Param1=Param1Vaule&Param2=Param2 Value&Param3=Param3 Value").
            Get("http://httpbin.org/get")
@jeevatkm jeevatkm self-assigned this Oct 7, 2015
@jeevatkm jeevatkm added this to the v0.3 Milestone milestone Oct 7, 2015
jeevatkm added a commit that referenced this issue Oct 8, 2015
@jeevatkm
#11 Request.SetQueryString method is done and test cases.
c9740e0
jeevatkm added a commit that referenced this issue Oct 8, 2015
@jeevatkm
Merging implementation of #8 & #11
17fa68e
@jeevatkm
Copy link
Member Author

jeevatkm commented Oct 8, 2015

Its done :)

@jeevatkm jeevatkm closed this as completed Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevatkm jeevatkm

Labels
enhancement
Milestone
v0.3 Milestone
Development

No branches or pull requests
1 participant
@jeevatkm