Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable proper retrying of POST requests #47

Closed
drichelson opened this issue Dec 4, 2016 · 5 comments
Closed

Enable proper retrying of POST requests #47

drichelson opened this issue Dec 4, 2016 · 5 comments
Assignees
Labels

Comments

@drichelson
Copy link

It looks like retries on POST requests do not resend the request body. Some would suggest that POSTs should not be retried, but in my case the request is idempotent, so it's fine. It should be noted that the log indicates the retried attempt contains the post body, but it's not actually there.

@jeevatkm jeevatkm self-assigned this Dec 4, 2016
@jeevatkm
Copy link
Member

jeevatkm commented Dec 4, 2016

@drichelson Thanks for reporting, I will have a look. If you have a sample code, please post it here.

@jeevatkm jeevatkm added this to the v0.10 Milestone milestone Dec 4, 2016
@drichelson
Copy link
Author

I created a failing test (with some heavy logging) to illustrate this issue: https://github.com/go-resty/resty/pull/48/files

@jeevatkm
Copy link
Member

jeevatkm commented Dec 4, 2016

Thanks for the PR. I will have a look.

@jeevatkm jeevatkm added bug and removed analysis labels Dec 29, 2016
jeevatkm added a commit that referenced this issue Dec 29, 2016
@drichelson
Copy link
Author

Thanks @jeevatkm !

@jeevatkm
Copy link
Member

@drichelson You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants