Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the applying order of PathParams #519

Closed
fwang2002 opened this issue Feb 14, 2022 · 2 comments · Fixed by #705
Closed

the applying order of PathParams #519

fwang2002 opened this issue Feb 14, 2022 · 2 comments · Fixed by #705
Assignees
@jeevatkm
Milestone
v2.9.0

Comments

@fwang2002
Copy link

Why first applying PathParams from Request and then Client(in function parseRequestURL). While in other situations, the applying order will be first Client, then Request.
@jeevatkm
Copy link
Member

@fwang2002 Thanks for reporting an issue. I just validated that you're correct. It seems I missed that point during the PR review.
Yes, the first is the client path params, and then the request path params. Typically in resty request values override the client values.

@jeevatkm jeevatkm self-assigned this Sep 24, 2023
@jeevatkm jeevatkm added the bug label Sep 24, 2023
@jeevatkm jeevatkm added this to the v2.9.0 milestone Sep 24, 2023
jeevatkm added a commit that referenced this issue Sep 24, 2023
@jeevatkm
fix: correct url path params processing order #519
28012cc
@jeevatkm jeevatkm mentioned this issue Sep 24, 2023
Merged
jeevatkm added a commit that referenced this issue Sep 24, 2023
@jeevatkm
fix: correct url path params processing order #519 (#705)
0424ad1
@SVilgelm
Copy link
Contributor

The original implementation was correct, please see the comment in the pull request. I can later today create another pull request with the unit tests

jeevatkm added a commit that referenced this issue Sep 24, 2023
@jeevatkm
Revert "fix: correct url path params processing order #519 (#705)"
9374c4d 
This reverts commit 0424ad1.
jeevatkm added a commit that referenced this issue Sep 24, 2023
@jeevatkm
Revert "fix: correct url path params processing order #519 (#705)" (#708
1ae2aac 
)

This reverts commit 0424ad1.
@jeevatkm jeevatkm removed the bug label Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevatkm jeevatkm

Labels
None yet
Milestone
v2.9.0
Development

Successfully merging a pull request may close this issue.

fix: correct url path params processing order #519 go-resty/resty
3 participants
@SVilgelm @jeevatkm @fwang2002