Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nil Pointer access on timeout using retry #58

Closed
ChristianLohmann opened this issue Mar 3, 2017 · 3 comments
Closed

Nil Pointer access on timeout using retry #58

ChristianLohmann opened this issue Mar 3, 2017 · 3 comments
Assignees
@jeevatkm
Labels
enhancement
Milestone
v0.11 Milestone

Comments

@ChristianLohmann
Copy link

When a request interrupts due to a client timeout and when using a retry condition function then the underlying resty.Response.RawResponse is nil. Which is pretty obvious because the remote haven't sent any. But one has to make a nil check on the RawResponse in RetryConditionFuncs because functions like resty.Response.StatusCode() access directly the underlying RawResponses fields.
@jeevatkm jeevatkm self-assigned this Mar 5, 2017
@jeevatkm jeevatkm added this to the v0.11 Milestone milestone Mar 5, 2017
@jeevatkm
Copy link
Member

jeevatkm commented Mar 5, 2017

@ChristianLohmann Thanks for your inputs. I will have a look and get back to you.

@jeevatkm
Copy link
Member

@ChristianLohmann I have added nil check while access RawResponse returns value appropriately. Will be pushing the changes tomorrow and also making v0.11 release.

jeevatkm added a commit that referenced this issue Mar 19, 2017
@jeevatkm
#58 enhancement on handling response
506bd6a
@ChristianLohmann
Copy link
Author

Thanks for that @jeevatkm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevatkm jeevatkm

Labels
enhancement
Milestone
v0.11 Milestone
Development

No branches or pull requests
2 participants
@jeevatkm @ChristianLohmann